Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI #89

Closed

Conversation

jasikpark
Copy link
Collaborator

@jasikpark jasikpark commented Jan 13, 2023

Fixes #88

Adds Format and Type checking in github actions, similar to https://github.com/DefinedNet/dn-docs/blob/main/.github/workflows/ci.yaml

Authored in gitpod.io, which is why this is coming as a fork rather than direct branch xD

We have "require approval for first time contributors" turned on for running workflows.

image

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for nebula-docs-dn ready!

Name Link
🔨 Latest commit 5ba9447
🔍 Latest deploy log https://app.netlify.com/sites/nebula-docs-dn/deploys/63c19cd05d34030009d592d4
😎 Deploy Preview https://deploy-preview-89--nebula-docs-dn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jasikpark
Copy link
Collaborator Author

Not sure why the actions aren't running?

@jasikpark
Copy link
Collaborator Author

Oh, needed to enable "run all actions" rather than just DN authored actions.

Copy link
Collaborator

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the setting to all outside collaborators for now. If that becomes a burden we can change it back.

.github/workflows/ci.yaml Show resolved Hide resolved
.github/workflows/ci.yaml Show resolved Hide resolved
@jasikpark
Copy link
Collaborator Author

closing in favor of a local branch

@jasikpark jasikpark closed this Jan 18, 2023
@jasikpark jasikpark deleted the jasikpark/duplicate-dn-docs-ci-88 branch January 18, 2023 19:44
@jasikpark jasikpark mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate dn-docs ci here
2 participants